test: change var to const for require and strict equality checks#9892
Closed
harishtejwani wants to merge 1 commit intonodejs:masterfrom
Closed
test: change var to const for require and strict equality checks#9892harishtejwani wants to merge 1 commit intonodejs:masterfrom
harishtejwani wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Dec 1, 2016
imyller
added
the
code-and-learn
Member
lpinca
approved these changes
Dec 3, 2016
jasnell
approved these changes
Dec 4, 2016
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
LGTM! thank you for the PR and for participating in the code-and-learn
jasnell
pushed a commit
that referenced
this pull request
Dec 4, 2016
PR-URL: #9892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
|
Landed in efdaeb0. thank you! |
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
PR-URL: #9892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
PR-URL: nodejs#9892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 20, 2016
PR-URL: #9892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
PR-URL: #9892 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test
Description of change
change var to const for require and added strict equality checks